Node 0.6x fixes#34
Merged
tbranyen merged 3 commits intonodegit:0.0.6nodegit/nodegit:0.0.6from Dec 14, 2011
Merged
Conversation
tbranyen
added a commit
that referenced
this pull request
Dec 14, 2011
Node 0.6x fixes by a beautiful man
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with node v0.6.5 on Lion
$ ./configure
Checking for program gcc or cc : /usr/bin/gcc
Checking for program cpp : /usr/bin/cpp
Checking for program ar : /usr/bin/ar
Checking for program ranlib : /usr/bin/ranlib
Checking for program g++ or c++ : /usr/bin/g++
Checking for program ar : /usr/bin/ar
Checking for program ranlib : /usr/bin/ranlib
Checking for g++ : ok
Checking for node path : ok /usr/local/lib/node
Checking for node prefix : ok /usr/local
-- The C compiler identification is GNU
-- Checking whether C compiler has -isysroot
-- Checking whether C compiler has -isysroot - yes
-- Checking whether C compiler supports OSX deployment target flag
-- Checking whether C compiler supports OSX deployment target flag - yes
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Found ZLIB: /usr/lib/libz.dylib (found version "1.2.5")
-- Looking for include files CMAKE_HAVE_PTHREAD_H
-- Looking for include files CMAKE_HAVE_PTHREAD_H - found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/ghost/work/3rdparty_repos/nodegit/vendor/libgit2/build
'configure' finished successfully (1.126s)
$ make
Waf: Entering directory
/Users/ghost/work/3rdparty_repos/nodegit/build' Scanning dependencies of target git2 [ 2%] Building C object CMakeFiles/git2.dir/src/blob.c.o [ 4%] Building C object CMakeFiles/git2.dir/src/buffer.c.o [ 6%] Building C object CMakeFiles/git2.dir/src/cache.c.o [ 8%] Building C object CMakeFiles/git2.dir/src/commit.c.o [ 10%] Building C object CMakeFiles/git2.dir/src/config.c.o [ 12%] Building C object CMakeFiles/git2.dir/src/config_file.c.o [ 14%] Building C object CMakeFiles/git2.dir/src/delta-apply.c.o [ 17%] Building C object CMakeFiles/git2.dir/src/errors.c.o [ 19%] Building C object CMakeFiles/git2.dir/src/fetch.c.o [ 21%] Building C object CMakeFiles/git2.dir/src/filebuf.c.o [ 23%] Building C object CMakeFiles/git2.dir/src/fileops.c.o [ 25%] Building C object CMakeFiles/git2.dir/src/hash.c.o [ 27%] Building C object CMakeFiles/git2.dir/src/hashtable.c.o [ 29%] Building C object CMakeFiles/git2.dir/src/index.c.o [ 31%] Building C object CMakeFiles/git2.dir/src/indexer.c.o [ 34%] Building C object CMakeFiles/git2.dir/src/mwindow.c.o [ 36%] Building C object CMakeFiles/git2.dir/src/netops.c.o [ 38%] Building C object CMakeFiles/git2.dir/src/object.c.o [ 40%] Building C object CMakeFiles/git2.dir/src/odb.c.o [ 42%] Building C object CMakeFiles/git2.dir/src/odb_loose.c.o [ 44%] Building C object CMakeFiles/git2.dir/src/odb_pack.c.o [ 46%] Building C object CMakeFiles/git2.dir/src/oid.c.o [ 48%] Building C object CMakeFiles/git2.dir/src/pack.c.o [ 51%] Building C object CMakeFiles/git2.dir/src/path.c.o [ 53%] Building C object CMakeFiles/git2.dir/src/pkt.c.o [ 55%] Building C object CMakeFiles/git2.dir/src/posix.c.o [ 57%] Building C object CMakeFiles/git2.dir/src/pqueue.c.o [ 59%] Building C object CMakeFiles/git2.dir/src/reflog.c.o [ 61%] Building C object CMakeFiles/git2.dir/src/refs.c.o [ 63%] Building C object CMakeFiles/git2.dir/src/refspec.c.o [ 65%] Building C object CMakeFiles/git2.dir/src/remote.c.o [ 68%] Building C object CMakeFiles/git2.dir/src/repository.c.o [ 70%] Building C object CMakeFiles/git2.dir/src/revwalk.c.o [ 72%] Building C object CMakeFiles/git2.dir/src/sha1.c.o [ 74%] Building C object CMakeFiles/git2.dir/src/sha1_lookup.c.o [ 76%] Building C object CMakeFiles/git2.dir/src/signature.c.o [ 78%] Building C object CMakeFiles/git2.dir/src/status.c.o [ 80%] Building C object CMakeFiles/git2.dir/src/tag.c.o [ 82%] Building C object CMakeFiles/git2.dir/src/thread-utils.c.o [ 85%] Building C object CMakeFiles/git2.dir/src/transport.c.o [ 87%] Building C object CMakeFiles/git2.dir/src/transport_git.c.o [ 89%] Building C object CMakeFiles/git2.dir/src/transport_local.c.o [ 91%] Building C object CMakeFiles/git2.dir/src/tree.c.o [ 93%] Building C object CMakeFiles/git2.dir/src/tsort.c.o [ 95%] Building C object CMakeFiles/git2.dir/src/util.c.o [ 97%] Building C object CMakeFiles/git2.dir/src/vector.c.o [100%] Building C object CMakeFiles/git2.dir/src/unix/map.c.o Linking C shared library libgit2.dylib [100%] Built target git2 [ 1/13] cxx: src/base.cc -> build/Release/src/base_1.o [ 2/13] cxx: src/sig.cc -> build/Release/src/sig_1.o [ 3/13] cxx: src/blob.cc -> build/Release/src/blob_1.o [ 4/13] cxx: src/error.cc -> build/Release/src/error_1.o [ 5/13] cxx: src/object.cc -> build/Release/src/object_1.o [ 6/13] cxx: src/reference.cc -> build/Release/src/reference_1.o [ 7/13] cxx: src/repo.cc -> build/Release/src/repo_1.o [ 8/13] cxx: src/commit.cc -> build/Release/src/commit_1.o [ 9/13] cxx: src/oid.cc -> build/Release/src/oid_1.o [10/13] cxx: src/revwalk.cc -> build/Release/src/revwalk_1.o [11/13] cxx: src/tree.cc -> build/Release/src/tree_1.o [12/13] cxx: src/tree_entry.cc -> build/Release/src/tree_entry_1.o [13/13] cxx_link: build/Release/src/base_1.o build/Release/src/sig_1.o build/Release/src/blob_1.o build/Release/src/error_1.o build/Release/src/object_1.o build/Release/src/reference_1.o build/Release/src/repo_1.o build/Release/src/commit_1.o build/Release/src/oid_1.o build/Release/src/revwalk_1.o build/Release/src/tree_1.o build/Release/src/tree_entry_1.o -> build/Release/nodegit.node Waf: Leaving directory/Users/ghost/work/3rdparty_repos/nodegit/build''build' finished successfully (9.405s)
$ make test
The "sys" module is now called "util". It should have a similar interface.
raw-blob.js
✔ constructor
✔ lookup
✔ rawContent
✔ rawSize
✔ close
✔ createFromFile
✔ createFromBuffer
raw-commit.js
✔ constructor
✔ lookup
raw-error.js
✔ constructor
✔ str_error
raw-object.js
✔ constructor
raw-oid.js
✔ constructor
✔ mkstr
✔ fmt
✔ toString
raw-reference.js
✔ constructor
✔ lookup
raw-repo.js
✔ constructor
✔ open
✔ free
✔ init
raw-revwalk.js
✔ constructor
convenience-repo.js
✔ method
✔ init
OK: 94 assertions (47ms)