From 4a326f11a751fbd2176c1e44284e231b4e28f333 Mon Sep 17 00:00:00 2001 From: Tim Branyen Date: Tue, 9 Dec 2014 15:13:34 -0500 Subject: [PATCH 1/5] Make remote#download async --- generate/input/descriptor.json | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json index 7d542b8e3..50b0be6f6 100644 --- a/generate/input/descriptor.json +++ b/generate/input/descriptor.json @@ -1115,6 +1115,12 @@ "remote": { "cType": "git_remote", "functions": { + "git_remote_download": { + "isAsync": true, + "return": { + "isErrorCode": true + } + }, "git_remote_default_branch": { "ignore": true }, From 2094b51f4d772bb523a5168fa8120da63b97e082 Mon Sep 17 00:00:00 2001 From: Tim Branyen Date: Mon, 12 Jan 2015 10:54:13 -0500 Subject: [PATCH 2/5] Minor test tweak --- test/tests/remote.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/test/tests/remote.js b/test/tests/remote.js index af2354491..04ce17ca5 100644 --- a/test/tests/remote.js +++ b/test/tests/remote.js @@ -91,15 +91,9 @@ describe("Remote", function() { it("can download from a remote", function() { var repo = this.repository; - return Remote.load(repo, "origin") - .then(function(remote) { + return Remote.load(repo, "origin").then(function(remote) { remote.connect(NodeGit.Enums.DIRECTION.FETCH); return remote.download(); - }) - .then(function() { - assert(true); - }, function() { - assert(false); }); }); @@ -114,7 +108,7 @@ describe("Remote", function() { it("can fetch from all remotes", function() { // Set a reasonable timeout here for the fetchAll test this.timeout(15000); - + return this.repository.fetchAll({ credentials: function(url, userName) { return NodeGit.Cred.sshKeyFromAgent(userName); From 34b72a94326f4544f1a849ac9b24d0ed81ff57d8 Mon Sep 17 00:00:00 2001 From: Tim Branyen Date: Wed, 28 Jan 2015 20:35:02 -0500 Subject: [PATCH 3/5] Change test slightly --- test/tests/remote.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/tests/remote.js b/test/tests/remote.js index 04ce17ca5..4eb6f1505 100644 --- a/test/tests/remote.js +++ b/test/tests/remote.js @@ -91,7 +91,7 @@ describe("Remote", function() { it("can download from a remote", function() { var repo = this.repository; - return Remote.load(repo, "origin").then(function(remote) { + return repo.getRemote("origin").then(function(remote) { remote.connect(NodeGit.Enums.DIRECTION.FETCH); return remote.download(); }); From 3a4060dc84c734bc5aa57d3081af9f629a216172 Mon Sep 17 00:00:00 2001 From: Maximiliano Korp Date: Fri, 30 Jan 2015 09:05:31 -0700 Subject: [PATCH 4/5] expose actual issue with remote.connect --- generate/input/descriptor.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json index 50b0be6f6..3cf5bda01 100644 --- a/generate/input/descriptor.json +++ b/generate/input/descriptor.json @@ -1115,6 +1115,11 @@ "remote": { "cType": "git_remote", "functions": { + "git_remote_connect": { + "return": { + "isErrorCode": true + } + }, "git_remote_download": { "isAsync": true, "return": { From 3e1daaebd99d686ac264f108d3d06e06844e811f Mon Sep 17 00:00:00 2001 From: Tim Branyen Date: Fri, 6 Feb 2015 19:11:16 -0500 Subject: [PATCH 5/5] Attempting to fix cert errors with os x --- test/tests/remote.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/tests/remote.js b/test/tests/remote.js index 4eb6f1505..a6cc28a37 100644 --- a/test/tests/remote.js +++ b/test/tests/remote.js @@ -92,7 +92,10 @@ describe("Remote", function() { var repo = this.repository; return repo.getRemote("origin").then(function(remote) { + remote.checkCert(0); + remote.connect(NodeGit.Enums.DIRECTION.FETCH); + return remote.download(); }); });