Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make remote#download async#326

Merged
tbranyen merged 5 commits intomasternodegit/nodegit:masterfrom
remote-download-asyncnodegit/nodegit:remote-download-asyncCopy head branch name to clipboard
Feb 7, 2015
Merged

Make remote#download async#326
tbranyen merged 5 commits intomasternodegit/nodegit:masterfrom
remote-download-asyncnodegit/nodegit:remote-download-asyncCopy head branch name to clipboard

Conversation

@tbranyen
Copy link
Member

@tbranyen tbranyen commented Dec 9, 2014

No description provided.

@johnhaley81 johnhaley81 added this to the 0.3.0 milestone Jan 19, 2015
@tbranyen tbranyen force-pushed the remote-download-async branch 2 times, most recently from 7b594a7 to 9f9e306 Compare January 29, 2015 01:35
@tbranyen
Copy link
Member Author

Okay so the only hold up on this is OS X. Anyone have a machine they can test with?

@johnhaley81
Copy link
Collaborator

Confirmed that it is an error on OSX.

  101 passing (46s)
  1 pending
  1 failing

  1) Remote can download from a remote:
     Error: No transport bound to this remote

@maxkorp
Copy link
Collaborator

maxkorp commented Jan 30, 2015

Ruh Roh.
Looking at the diffs in libgit, the error has been updated in 0.22.x to "This remote has never connected". So a transport is not guaranteed to be set by libgit until you've already done a fetch, which sort of defeats the purpose. It's just odd that it works in win/nix.

I'm digging a bit deeper now, but we may have to play some games in the C++, but we're gonna have to work in there soon for the iterator stuff, so maybe it's time. Perhaps some sort of generating functions both sync and async with a fallback, or something.

@tbranyen tbranyen force-pushed the remote-download-async branch 2 times, most recently from 608128b to 841a2bc Compare February 7, 2015 00:39
@tbranyen tbranyen force-pushed the remote-download-async branch from 841a2bc to 3e1daae Compare February 7, 2015 03:26
tbranyen added a commit that referenced this pull request Feb 7, 2015
@tbranyen tbranyen merged commit fc434a9 into master Feb 7, 2015
@tbranyen tbranyen deleted the remote-download-async branch February 7, 2015 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.