Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update appveyor.yml to remove project id#324

Merged
tbranyen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
vladikoff:patch-1vladikoff/nodegit:patch-1Copy head branch name to clipboard
Dec 9, 2014
Merged

Update appveyor.yml to remove project id#324
tbranyen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
vladikoff:patch-1vladikoff/nodegit:patch-1Copy head branch name to clipboard

Conversation

@vladikoff
Copy link
Contributor

No description provided.

@tbranyen
Copy link
Member

tbranyen commented Dec 9, 2014

Do we just not need the id or why was this removed?

@vladikoff
Copy link
Contributor Author

From the support email Recent AppVeyor update added strict YAML schema validation."
so it seems like we need to update our YAMLs. Lets see if the build passes

@tbranyen
Copy link
Member

tbranyen commented Dec 9, 2014

@vladikoff can you remove the slack integration from appveyor to see if it triggers a pass?

@vladikoff
Copy link
Contributor Author

Updated

@johnhaley81
Copy link
Collaborator

@vladikoff could you include the relevant part of the email explaining why the project id isn't needed anymore please?

@tbranyen
Copy link
Member

tbranyen commented Dec 9, 2014

Awesome, looks like that worked! Thanks @vladikoff.

@johnhaley81 relevant URL: appveyor/ci#1 (comment)

@tbranyen tbranyen closed this Dec 9, 2014
@tbranyen
Copy link
Member

tbranyen commented Dec 9, 2014

F! I'll manually merge.

Nevermind...

@tbranyen tbranyen reopened this Dec 9, 2014
tbranyen added a commit that referenced this pull request Dec 9, 2014
Update appveyor.yml to remove project id
@tbranyen tbranyen merged commit a65ff08 into nodegit:master Dec 9, 2014
@vladikoff vladikoff deleted the patch-1 branch December 9, 2014 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.