Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

detect node-webkit and build with nw-gyp#309

Merged
maxkorp merged 2 commits intomasternodegit/nodegit:masterfrom
node-webkitnodegit/nodegit:node-webkitCopy head branch name to clipboard
Dec 1, 2014
Merged

detect node-webkit and build with nw-gyp#309
maxkorp merged 2 commits intomasternodegit/nodegit:masterfrom
node-webkitnodegit/nodegit:node-webkitCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Dec 1, 2014

The process here is as such

  • Recursively go up the path looking for package.json files.
  • When we find the last one, look to see if it has an engines setting, and if it does, look to see if it contains a setting for node-webkit
  • If there is a setting, we grab its version
  • If we have a node-webkit setting, skip the fetch (we can possibly fix this later?)
  • When building, choose between node-gyp and nw-gyp based on having found a node-webkit version
  • Set the target for nw-gyp configure to the version found earlier.

@maxkorp
Copy link
Collaborator Author

maxkorp commented Dec 1, 2014

This fixes #212 (with some caveats) and should resolve other similar issues from coming up. I'm going to make a note in the readme. Going to vote for very tight version support for node-webkit, as that bumps versions (breakingly so) quite often.

maxkorp added a commit that referenced this pull request Dec 1, 2014
detect node-webkit and build with nw-gyp
@maxkorp maxkorp merged commit 624e7a8 into master Dec 1, 2014
@maxkorp maxkorp deleted the node-webkit branch December 5, 2014 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.