Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add history.md and update readme#291

Merged
maxkorp merged 2 commits intomasternodegit/nodegit:masterfrom
bump-version-docsnodegit/nodegit:bump-version-docsCopy head branch name to clipboard
Nov 25, 2014
Merged

add history.md and update readme#291
maxkorp merged 2 commits intomasternodegit/nodegit:masterfrom
bump-version-docsnodegit/nodegit:bump-version-docsCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Nov 24, 2014

No description provided.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing capitalization for additionally.
  • Callbacks still work, or should, we want to support both styles as much as possible.

@maxkorp
Copy link
Collaborator Author

maxkorp commented Nov 25, 2014

interesting, didnt see that. I'll fix it up really quickly. Are we sure CBs still work? Even when there are optional paramaters being left out?

maxkorp added a commit that referenced this pull request Nov 25, 2014
@maxkorp maxkorp merged commit 9412ebc into master Nov 25, 2014
@maxkorp maxkorp deleted the bump-version-docs branch November 25, 2014 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.