Refactor classes#250
Merged
Conversation
also blocks instantiation of types from JS
Collaborator
Author
|
Added |
53bd878 to
266376e
Compare
Member
|
Thanks for this! |
Collaborator
|
This fixes #240. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many methods like createCommit to create.
Added a test to revwalk to make sure there is no segfault, but wont run on travis/appveyor because it requires a node argument. Might be worth moving out anyways, as its not really a revwalk test, that was just the mechanism that originally broke it.