Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refactor classes#246

Merged
tbranyen merged 7 commits intoclone-methodsnodegit/nodegit:clone-methodsfrom
refactor-classesnodegit/nodegit:refactor-classesCopy head branch name to clipboard
Oct 23, 2014
Merged

Refactor classes#246
tbranyen merged 7 commits intoclone-methodsnodegit/nodegit:clone-methodsfrom
refactor-classesnodegit/nodegit:refactor-classesCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Oct 17, 2014

WIP

@maxkorp maxkorp force-pushed the refactor-classes branch 2 times, most recently from 501ccca to fee0348 Compare October 17, 2014 18:19
@maxkorp
Copy link
Collaborator Author

maxkorp commented Oct 17, 2014

Made one commit that causes the test to fail normally as it is on clone-methods, rather than blowing everything up entirely. 2 failures, the same exact as on clone-methods. Want to do some memory checking, because there is a risk some leaks were introduced, but conversely a lot of inappropriate frees were removed.

Note, this works under the assumption that git_{type}_free always frees any instances of the datatypes that it has pointers to as well, which as far as @johnhaley81 and I can tell is always the case.

@maxkorp
Copy link
Collaborator Author

maxkorp commented Oct 22, 2014

OK, so all the tests run locally for me except clone ssh (which segfaults), but that fails upstream as well. This is ready for a quick review and then it can merge in.

@johnhaley81
Copy link
Collaborator

You guys want to merge this in after CI is done?

@tbranyen
Copy link
Member

Yup, should be maybe 10-20 minutes

tbranyen added a commit that referenced this pull request Oct 23, 2014
@tbranyen tbranyen merged commit 28d58e6 into clone-methods Oct 23, 2014
@tbranyen tbranyen deleted the refactor-classes branch October 23, 2014 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.