Add revwalk.hide and revwalk.simplifyFirstParent#234
Add revwalk.hide and revwalk.simplifyFirstParent#234tbranyen merged 2 commits intonodegit:masternodegit/nodegit:masterfrom orderedlist:revwalk-additionsorderedlist/nodegit:revwalk-additionsCopy head branch name to clipboard
Conversation
|
Looks like incorrect SHA's in the CI. Was this passing locally for you? |
|
Yeah, passed locally. Let me dig into the CI. Might need to be more explicit with the initial SHAs I use. |
|
@tbranyen something's definitely happening with the SHAs. Does the test/repos/workdir repo change? |
|
It changes whenever NodeGit master is updated. If your revwalk code is expecting a certain order, that can't be guaranteed. |
|
Hey @orderedlist I have a commit that fixes the output to be correct and makes the tests easier to read. I can push it into your branch if you add me to your fork. See the change here: #235 |
|
@orderedlist you probably need to |
|
Ah nevermind, I'll just update the title of my PR and merge it that way. No real difference. Thanks for your help! |
|
@tbranyen thanks for the help! Hope to keep adding more in the future! |
|
Awesome looking forward to the help @orderedlist |
This PR adds the ability to hide OIDs from a revwalker, and the ability to limit the revwalker to only walk first parents.