Fix electron build#1901
Merged
ianhattendorf merged 3 commits intonodegit:masternodegit/nodegit:masterfrom Mar 21, 2022
ianhattendorf:fix/electron-installianhattendorf/nodegit:fix/electron-installCopy head branch name to clipboard
Merged
Fix electron build#1901ianhattendorf merged 3 commits intonodegit:masternodegit/nodegit:masterfrom ianhattendorf:fix/electron-installianhattendorf/nodegit:fix/electron-installCopy head branch name to clipboard
ianhattendorf merged 3 commits intonodegit:masternodegit/nodegit:masterfrom
ianhattendorf:fix/electron-installianhattendorf/nodegit:fix/electron-installCopy head branch name to clipboard
Conversation
Issues with mac and openssl_fips
Bring in newer packages, we're getting issues with outdated packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating node-gyp, we've been having issues building for electron (getting
openssl_fips != ""errors).This partially resolves the issue where setting the Electron version in
.npmrcbeforenpm iworks, howevernpx node-gyp rebuild ...after building for node still fails.