Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Better installation flow for developing.#180

Merged
3y3 merged 3 commits intomasternodegit/nodegit:masterfrom
better-flownodegit/nodegit:better-flowCopy head branch name to clipboard
Jun 20, 2014
Merged

Better installation flow for developing.#180
3y3 merged 3 commits intomasternodegit/nodegit:masterfrom
better-flownodegit/nodegit:better-flowCopy head branch name to clipboard

Conversation

@tbranyen
Copy link
Member

  • Detects if libgit2 is already fetched instead of constantly fetching.
  • Removes outdated libgit2 files.
  • Provides more meta information about libgit2 inside package.json.

tbranyen added 2 commits June 20, 2014 14:32
- Detects if libgit2 is already fetched instead of constantly fetching.
- Provides more meta information about libgit2 inside package.json.
@3y3
Copy link
Contributor

3y3 commented Jun 20, 2014

About fetching libgit2: is it possible what fetched library has old uncompatible version?

@tbranyen
Copy link
Member Author

Yes, that is a good point. What would you suggest to handle this? Should I write out a tracking file named something like sha that contains the currently installed sha? That way we can compare and wipe out if it's outdated.

@tbranyen
Copy link
Member Author

Actually I could just write a file named identical to the sha and fs.stat that for testing.

@3y3
Copy link
Contributor

3y3 commented Jun 20, 2014

I think, will be enough to parse ./vendor/libgit2/include/git2/version.h

@3y3
Copy link
Contributor

3y3 commented Jun 20, 2014

Your solution will be simple

@tbranyen tbranyen changed the title Better flow for development. Better installation flow for developing. Jun 20, 2014
@tbranyen
Copy link
Member Author

If this looks good to you @3y3 can you merge?

package.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is used pkg.libgit2.libgit2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowhere, must be remnant from something else. Good catch, removed.

@3y3
Copy link
Contributor

3y3 commented Jun 20, 2014

Ok, I'm ready to merge it.
I have question about checking python current realisation working fine, but if exclude users of python 1.*(seriously dinosaurs knows about github?), the checking can be simplified.

@tbranyen
Copy link
Member Author

@3y3 the checking is between python2 and python3 not python1. On systems like Arch Linux python defaults to 3 which doesn't work here. python2 is the aliased form.

3y3 added a commit that referenced this pull request Jun 20, 2014
Better installation flow for developing.
@3y3 3y3 merged commit 8613a3e into master Jun 20, 2014
@3y3
Copy link
Contributor

3y3 commented Jun 20, 2014

Oh - now it's clearly. Merged.

@tbranyen
Copy link
Member Author

Awesome, thanks!

@tbranyen tbranyen deleted the better-flow branch June 20, 2014 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.