Refactor for context-awareness#1795
Merged
implausible merged 40 commits intonodegit:masternodegit/nodegit:masterfrom Oct 20, 2020
ianhattendorf:refactor/context-awarenessianhattendorf/nodegit:refactor/context-awarenessCopy head branch name to clipboard
Merged
Refactor for context-awareness#1795implausible merged 40 commits intonodegit:masternodegit/nodegit:masterfrom ianhattendorf:refactor/context-awarenessianhattendorf/nodegit:refactor/context-awarenessCopy head branch name to clipboard
implausible merged 40 commits intonodegit:masternodegit/nodegit:masterfrom
ianhattendorf:refactor/context-awarenessianhattendorf/nodegit:refactor/context-awarenessCopy head branch name to clipboard
Conversation
Until node understands how to cleanup a native node module asynchronously, we cannot allow nodegit to operate in a worker thread or it will die on exit. Other concerns... Process reuse in Electron may be a problem without async cleanup being a real thing.
We aren't allowed to call back to JavaScript in this case
Ensure baton data members are value initialized (since batons are trivial types)
We already lock in AcquireLocks
RHEL 7 is still fairly popular and on GCC 4.8.x
Windows fails to shutdown synchronously, so shutdown asynchronously. This is only supported by node 14.10+ currently. Should be backported to LTS releases shortly
implausible
reviewed
Sep 11, 2020
implausible
reviewed
Sep 11, 2020
Member
|
hooo weee... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR:
worker_threadsupport!app.allowRendererProcessReuse=trueFixes #1774