NodeJS v0.11.13 compatibility#175
NodeJS v0.11.13 compatibility#1753y3 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom 3y3:masterCopy head branch name to clipboard
Conversation
|
I work on errors and I'll call, when this will be ready to review. If someone has a time - help me, please. |
|
Awesome, thanks for submitting this! I'll review and try and help, and recruit. |
|
@3y3 can you limit the use of squash and force on this branch now that it's linked to a PR? |
|
ok, now I move my test to private branch. You are welcome. |
|
Thanks! I was just getting confused when SHAs became inconsistent. |
|
@tbranyen , pr was builded and passed the tests. Error on 0.8.0 is not a problem of pr. Ready to review (or I can squash it previously) |
|
Whoa nice! Thanks for this. |
|
@3y3 if you fetch latest, rebase to master, and force push back up Travis won't test 0.8 and your PR will pass. |
|
@tbranyen , all ready. |
|
@3y3 added you to the organization, feel free to merge when you're ready. Hope to see more great work from ya! |
|
Thank you. I merge this and start to read Descriptor refactor. |
|
Landed as c518174 |
|
@tbranyen , I'm really sorry - in three thousands of changed lines I missed one important unrelated change . Which strategy to clear this is preferred - new commit, new pr, or overriding? |
|
No big deal, I'm fighting with AppVeyor at the moment to get our Windows builds passing. I'd just hotfix directly to master. |
|
Also maybe you have perspective on #165 now :-) |
No description provided.