Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

changed wording to be better#1381

Closed
TomOrth wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom
TomOrth:masterTomOrth/nodegit:masterCopy head branch name to clipboard
Closed

changed wording to be better#1381
TomOrth wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom
TomOrth:masterTomOrth/nodegit:masterCopy head branch name to clipboard

Conversation

@TomOrth
Copy link

@TomOrth TomOrth commented Oct 2, 2017

No description provided.

@cjhoward92
Copy link
Collaborator

I'm not sure I find this wording to be really that much better. I would prefer a reference to the build section as opposed to Please see the above steps on how to do so. I would also like the Note to be separated out, not in parentheses after the previous statement.

I would also change the line Run the following command to run the tests. to maybe read:

Use npm test to run the tests.

No need to have a separate section for a single, two word command.

Also, sorry for the late response. We all appreciate your contribution! Thank you so much for taking the time to do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.