Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use wider int to calculate throttle window#1232

Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
srajko:throttle-overflow-fixsrajko/nodegit:throttle-overflow-fixCopy head branch name to clipboard
Feb 28, 2017
Merged

Use wider int to calculate throttle window#1232
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
srajko:throttle-overflow-fixsrajko/nodegit:throttle-overflow-fixCopy head branch name to clipboard

Conversation

@srajko
Copy link
Collaborator

@srajko srajko commented Feb 24, 2017

Sufficiently large throttle values would cause an overflow - the cast coerces the computation into a sufficiently large int

@johnhaley81
Copy link
Collaborator

Not totally sure why, but this is killing linux 32-bit.

@johnhaley81 johnhaley81 force-pushed the throttle-overflow-fix branch from 981bea6 to c018da1 Compare February 28, 2017 15:15
@johnhaley81
Copy link
Collaborator

32-bit linux dieing was unrelated and fixed in #1241

@johnhaley81 johnhaley81 merged commit 07da8b4 into nodegit:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.