String message argument of Stash.save is optional#1215
Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Feb 26, 2017
Merged
String message argument of Stash.save is optional#1215johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
message argument of Stash.save is optional#1215johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
Conversation
libgit2's git_stash_save function does not actually require the message to be set. One will be generated if a message is not given so the parameter should be flagged as being optional in NodeGit as well.
Collaborator
|
Thanks @rcjsuen for the great PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you look at libgit2's stash.h file, you will see that the
messageparameter is actually optional. We should flag the argument as being optional in NodeGit's JSON file as well.