Make Reset.fromAnnotated the same as Reset.reset#1214
Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Feb 26, 2017
Merged
Make Reset.fromAnnotated the same as Reset.reset#1214johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
Reset.fromAnnotated the same as Reset.reset#1214johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
Conversation
The reset function is asynchronous and also flags its checkout options as being optional. fromAnnotated should be updated accordingly as the two functions basically do the same thing.
Collaborator
|
Thanks @rcjsuen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fromAnnotatedfunction should be asynchronous in addition to having itscheckout_optsparameter be optional as the function delegates to the same function asresetinternally in libgit2.