Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Build for Node 7.4.0#1204

Merged
tbranyen merged 1 commit intomasternodegit/nodegit:masterfrom
node-7nodegit/nodegit:node-7Copy head branch name to clipboard
Jan 29, 2017
Merged

Build for Node 7.4.0#1204
tbranyen merged 1 commit intomasternodegit/nodegit:masterfrom
node-7nodegit/nodegit:node-7Copy head branch name to clipboard

Conversation

@tbranyen
Copy link
Member

@tbranyen tbranyen commented Jan 29, 2017

Testing out build support on Travis... built locally, but hitting weird error:


#
# Fatal error in ../deps/v8/src/api.cc, line 1051
# Check failed: !value_obj->IsJSReceiver() || value_obj->IsTemplateInfo().
#

==== C stack trace ===============================

    /usr/bin/node(v8::base::debug::StackTrace::StackTrace()+0x16) [0x106bda6]
    /usr/bin/node(V8_Fatal+0xe8) [0x1069fe8]
    /usr/bin/node(v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)+0xff) [0x76094f]
    /home/tim/git/nodegit/nodegit/build/Release/nodegit.node(Wrapper::InitializeComponent(v8::Local<v8::Object>)+0x26d) [0x7fc0c190f58d]
    /home/tim/git/nodegit/nodegit/build/Release/nodegit.node(init+0x43) [0x7fc0c190d8a3]
    /usr/bin/node(node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)+0x365) [0xf51285]
    /usr/bin/node(v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))+0x12f) [0x78d6ef]
    /usr/bin/node() [0x7f2bb8]
    /usr/bin/node() [0x7f2f50]
    /usr/bin/node(v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)+0x2b) [0x7f312b]
    [0x3856731063a7]

@tbranyen
Copy link
Member Author

tbranyen commented Jan 29, 2017

Well that was unexpected... https://travis-ci.org/nodegit/nodegit/jobs/196246148

@johnhaley81
Copy link
Collaborator

johnhaley81 commented Jan 29, 2017

Wat

johnhaley81
johnhaley81 reviewed Jan 29, 2017
View reviewed changes
.travis.yml
- export NODE_VERSION="7.4" TARGET_ARCH="x64"

matrix:
fast_finish: true
Copy link
Collaborator

@johnhaley81 johnhaley81 Jan 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 32-bit, it needs to be added to the matrix below as well.

Copy link
Member Author

@tbranyen tbranyen Jan 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool, I also updated appveyor locally.

@johnhaley81
Copy link
Collaborator

johnhaley81 commented Jan 29, 2017

Uhh sooo apparently we didn't need to modify OpenSSL after all for this bump. Which was the problem last time I tried this. Something must have changed between 7.0 and 7.4 or I'm losing my mind (also possible).

@tbranyen
Copy link
Member Author

tbranyen commented Jan 29, 2017

I also bumped node-pre-gyp and node-gyp in here, might have had something to do with it?

@johnhaley81
Copy link
Collaborator

johnhaley81 commented Jan 29, 2017

Ahhh yeah that could be it. Good call.

@tbranyen
Copy link
Member Author

tbranyen commented Jan 29, 2017

Sweet, good to merge?

@johnhaley81
Copy link
Collaborator

johnhaley81 commented Jan 29, 2017

👍

@tbranyen tbranyen merged commit 5b4bb8c into master Jan 29, 2017
@tbranyen tbranyen deleted the node-7 branch January 29, 2017 02:02
@johnhaley81 johnhaley81 changed the title Node 7.4.0 Build for Node 7.4.0 Feb 6, 2017
@jacobq jacobq mentioned this pull request Jan 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnhaley81 johnhaley81 johnhaley81 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbranyen @johnhaley81
Morty Proxy This is a proxified and sanitized view of the page, visit original site.