escape the spaces in dir for shell command#1186
Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Jan 27, 2017
iloahz:masterCopy head branch name to clipboard
Merged
escape the spaces in dir for shell command#1186johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom iloahz:masterCopy head branch name to clipboard
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
iloahz:masterCopy head branch name to clipboard
Conversation
|
I'm hoping this can be merged in soon. Sadly I need this for my build system to work correctly. Edit: I ended up ditching |
Collaborator
|
Thanks @iloahz. Sorry that NodeGit didn't work for you @jacobmarshall. It is pretty big so I can understand it not fitting into your use case. |
Thanks @johnhaley81, I seriously appreciate your work. |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue in #1082