Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add @async tag to getEntry#1178

Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
rcjsuen:patch-2rcjsuen/nodegit:patch-2Copy head branch name to clipboard
Jan 27, 2017
Merged

Add @async tag to getEntry#1178
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
rcjsuen:patch-2rcjsuen/nodegit:patch-2Copy head branch name to clipboard

Conversation

@rcjsuen
Copy link
Member

@rcjsuen rcjsuen commented Jan 3, 2017

Fix the documentation generation for Tree's getEntry method so that it'll be properly tagged as ASYNC in the output.

This fixes nodegit.github.com issue #41.

The getEntry function is asynchronous so it should be tagged with
@async so the documentation will be generated correctly.
@johnhaley81
Copy link
Collaborator

Thanks @rcjsuen!

@johnhaley81 johnhaley81 merged commit 2fad578 into nodegit:master Jan 27, 2017
@rcjsuen rcjsuen deleted the patch-2 branch January 27, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree.getEntry is documented as SYNC

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.