Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix revwalk memory leaks #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 2 commits into from
Oct 7, 2016
Merged

Fix revwalk memory leaks #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55aacdb
Mark revwalk as selfFreeing
srajko Sep 23, 2016
c9a0daf
Add revwalk leak test
srajko Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions 4 generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,6 +2100,7 @@
"ignore": true
},
"revwalk": {
"selfFreeing": true,
"dependencies": [
"../include/commit.h",
"../include/functions/copy.h"
Expand All @@ -2108,9 +2109,6 @@
"git_revwalk_add_hide_cb": {
"ignore": true
},
"git_revwalk_free": {
"ignore": true
},
"git_revwalk_new": {
"isAsync": false
}
Expand Down
10 changes: 10 additions & 0 deletions 10 test/tests/revwalk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ var fse = promisify(require("fs-extra"));
var path = require("path");
var local = path.join.bind(path, __dirname);

var leakTest = require("../utils/leak_test");

describe("Revwalk", function() {
var NodeGit = require("../../");
var Repository = NodeGit.Repository;
Expand Down Expand Up @@ -309,6 +311,14 @@ describe("Revwalk", function() {
});
});

it("does not leak", function() {
var test = this;

return leakTest(NodeGit.Revwalk, function() {
return Promise.resolve(NodeGit.Revwalk.create(test.repository));
});
});

// This test requires forcing garbage collection, so mocha needs to be run
// via node rather than npm, with a la `node --expose-gc [pathtohmoca]
// [testglob]`
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.