patch libssh2 to work with vs2015#1125
Merged
Conversation
5fe111a to
f0b22df
Compare
Collaborator
|
One important thing is that the C++ code should not be built with platformtoolset v140 (default vs2015 mode) until node itself switches over, when using vs2015 one should use platformtoolset v120, which is vs2013 compatibility. The vs2015 module may appear to work at first but it might start to fail in some obscure and non-obvious situations requiring runtime C++ support! like exception stack unwinding or thread local storage, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with the windows SDK for vs2015, the build would die due to some duplicate defines.
Found a variation of this patch on github.com/libssh2/libssh2 for libssh2 1.7, which we still need to update to, but for now this works.