Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Don't run postbuild when we detect electron install#1111

Merged
maxkorp merged 2 commits intomasternodegit/nodegit:masterfrom
electron-no-postbuildnodegit/nodegit:electron-no-postbuildCopy head branch name to clipboard
Sep 15, 2016
Merged

Don't run postbuild when we detect electron install#1111
maxkorp merged 2 commits intomasternodegit/nodegit:masterfrom
electron-no-postbuildnodegit/nodegit:electron-no-postbuildCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Aug 15, 2016

Since we can't require it from node if it's compiled for electron, we should just assume success for now

Addresses #1095

Since we can't require it from node if it's compiled for electron, we should just assume success for now
@maxkorp maxkorp force-pushed the electron-no-postbuild branch from 5915426 to cfe280c Compare September 15, 2016 02:42
@maxkorp maxkorp merged commit 6da7d34 into master Sep 15, 2016
@maxkorp maxkorp deleted the electron-no-postbuild branch September 15, 2016 17:58
@maxkorp maxkorp removed the ready label Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.