Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use diff options even if the commit has no parent#1008

Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
smith-kyle:diff-optionssmith-kyle/nodegit:diff-optionsCopy head branch name to clipboard
Apr 27, 2016
Merged

Use diff options even if the commit has no parent#1008
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
smith-kyle:diff-optionssmith-kyle/nodegit:diff-optionsCopy head branch name to clipboard

Conversation

@smith-kyle
Copy link
Contributor

Commit#getDiffWithOptions did not use the diff options passed in if the commit did not have a parent.

@smith-kyle
Copy link
Contributor Author

This is related to #1002 in that the same error is thrown when trying to merge two diffs but this only fixes the case where one of the diffs comes from a commit without a parent

@johnhaley81
Copy link
Collaborator

Thanks @smith-kyle

@johnhaley81 johnhaley81 merged commit f5280aa into nodegit:master Apr 27, 2016
@smith-kyle smith-kyle deleted the diff-options branch April 27, 2016 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.