Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

libgit2 creation methods have name collisions with internal V8 functions #271

Copy link
Copy link
@johnhaley81

Description

@johnhaley81
Issue body actions

The classes and structs that have creation methods in libgit2 (e.g. git_revwalk_new) will have their methods reduced to just New which is a name collision with an internal method. Either we rename this method or rename these methods to be something else. Maybe turn git_revwalk_new into Create or CreateRevwalk. The latter will retain backwards compatibility but is a little redundant.

Thoughts?

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.