Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

nodegit installation falls back when Python install dir contains spaces #261

Copy link
Copy link
@ghost

Description

Hi folks,

I found a weird behaviour in the install.js script in 0.1.4. When the Python install folder location path contains spaces, then the following parsing logic fails:
python = results[0].value || results[1].value;

So the python string will be something like "C:\Program ". Then the subsequent functions fail of course.

Another and more serious problem is that the error message is swallowed in:

.fail(function(message) {
  console.info('[nodegit] Failed to build nodegit.');
  console.info('[nodegit] Attempting to fallback on a prebuilt binary.');
  ...
})

I can see that there were some major changes on master branch, I am just reporting this to watch out for this edge case also.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.