Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bb4c0bd

Browse filesBrowse files
Make Tree#createUpdated accept Array<TreeUpdate>
1 parent 76b3eab commit bb4c0bd
Copy full SHA for bb4c0bd

File tree

Expand file treeCollapse file tree

2 files changed

+12
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+12
-2
lines changed
Open diff view settings
Collapse file

‎generate/input/descriptor.json‎

Copy file name to clipboardExpand all lines: generate/input/descriptor.json
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2527,6 +2527,16 @@
25272527
"tree": {
25282528
"selfFreeing": true,
25292529
"functions": {
2530+
"git_tree_create_updated": {
2531+
"args": {
2532+
"updates": {
2533+
"cType": "git_tree_update *",
2534+
"cppClassName": "Array",
2535+
"jsClassName": "Array",
2536+
"arrayElementCppClassName": "GitTreeUpdate"
2537+
}
2538+
}
2539+
},
25302540
"git_tree_entry_byid": {
25312541
"return": {
25322542
"ownedByThis": true
Collapse file

‎generate/templates/partials/convert_from_v8.cc‎

Copy file name to clipboardExpand all lines: generate/templates/partials/convert_from_v8.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@
4848
{%elsif cppClassName == 'Array'%}
4949

5050
Array *tmp_{{ name }} = Array::Cast(*info[{{ jsArg }}]);
51-
from_{{ name }} = ({{ cType }})malloc(tmp_{{ name }}->Length() * sizeof({{ cType|replace '**' '*' }}));
51+
from_{{ name }} = ({{ cType }})malloc(tmp_{{ name }}->Length() * sizeof({{ cType|unPointer }}));
5252
for (unsigned int i = 0; i < tmp_{{ name }}->Length(); i++) {
5353
{%--
5454
// FIXME: should recursively call convertFromv8.
5555
--%}
56-
from_{{ name }}[i] = Nan::ObjectWrap::Unwrap<{{ arrayElementCppClassName }}>(tmp_{{ name }}->Get(Nan::New(static_cast<double>(i)))->ToObject())->GetValue();
56+
from_{{ name }}[i] = {%if not cType|isDoublePointer %}*{%endif%}Nan::ObjectWrap::Unwrap<{{ arrayElementCppClassName }}>(tmp_{{ name }}->Get(Nan::New(static_cast<double>(i)))->ToObject())->GetValue();
5757
}
5858
{%elsif cppClassName == 'Function'%}
5959
{%elsif cppClassName == 'Buffer'%}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.