Add toJSON function on RTCIceCandidate and RTCSessionDescription #701

challenger71498 · Jun 22, 2021

As MDN described, RTCIceCandidate and RTCSessionDescription on the web have toJSON, whose output is its own init value.

https://developer.mozilla.org/en-US/docs/Web/API/RTCSessionDescription/toJSON
https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidate/toJSON

However, node-webrtc does not implemented this yet, causing error as below:

awslabs/amazon-kinesis-video-streams-webrtc-sdk-js#115 (comment)

So I simply just put a toJSON method to them.

Snapu · Feb 24, 2022

Looks like the build failed because of quota issues? It would be nice to have this PR merged soon.

Snapu · Apr 27, 2022

@markandrus Are you going to look at this?

richieteh94 · Sep 1, 2022

I'm facing an issue where I got RTCSessionDescription got error where toJSON is not a function when using together with amazon-kinesis-video-streams-webrtc version 2.0.0 npm please help fix this issue ASAP. This issue occurs to me where I trying to recreate a sample of https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-js/blob/master/examples/viewer.js in nodejs application

C:\xx\xx\xx\webrtc master\node_modules\amazon-kinesis-video-streams-webrtc\lib\SignalingClient.js:139
        this.sendMessage(MessageType.SDP_OFFER, sdpOffer.toJSON(), recipientClientId);
                                                         ^

TypeError: sdpOffer.toJSON is not a function
    at SignalingClient.sendSdpOffer (C:\xx\xx\xx\webrtc master\node_modules\amazon-kinesis-video-streams-webrtc\lib\SignalingClient.js:139:58)
    at RTCPeerConnection.<anonymous> (C:\xx\xx\xx\webrtc master\dist\index.js:252:42)
    at C:\xx\xx\xx\webrtc master\node_modules\wrtc\lib\eventtarget.js:37:18
    at Set.forEach (<anonymous>)
    at C:\xx\xx\xx\webrtc master\node_modules\wrtc\lib\eventtarget.js:33:15
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

Update: same a goes to the https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-js/blob/master/examples/master.js

C:\xx\xx\xx\webrtc master\node_modules\amazon-kinesis-video-streams-webrtc\lib\SignalingClient.js:149
        this.sendMessage(MessageType.SDP_ANSWER, sdpAnswer.toJSON(), recipientClientId);
                                                           ^

TypeError: sdpAnswer.toJSON is not a function
    at SignalingClient.sendSdpAnswer (C:\xx\xx\xx\webrtc master\node_modules\amazon-kinesis-video-streams-webrtc\lib\SignalingClient.js:149:60)
    at RTCPeerConnection.<anonymous> (C:\xx\xx\xx\webrtc master\dist\index.js:104:46)
    at C:\xx\xx\xx\webrtc master\node_modules\wrtc\lib\eventtarget.js:37:18
    at Set.forEach (<anonymous>)
    at C:\xx\xx\xx\webrtc master\node_modules\wrtc\lib\eventtarget.js:33:15
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

challenger71498 added 2 commits June 21, 2021 17:20

Add toJSON function

0e21341

Modify out to be same as Web API

b33fc79

duvallj mentioned this pull request May 2, 2024

Merge Outstanding PRs From Upstream WonderInventions/node-webrtc#15

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add toJSON function on RTCIceCandidate and RTCSessionDescription #701

Add toJSON function on RTCIceCandidate and RTCSessionDescription #701

challenger71498 commented Jun 22, 2021

Snapu commented Feb 24, 2022

Snapu commented Apr 27, 2022

richieteh94 commented Sep 1, 2022 •

edited

Loading

Search code, repositories, users, issues, pull requests...

Add toJSON function on RTCIceCandidate and RTCSessionDescription #701

Are you sure you want to change the base?

Add toJSON function on RTCIceCandidate and RTCSessionDescription #701

Conversation

challenger71498 commented Jun 22, 2021

Snapu commented Feb 24, 2022

Snapu commented Apr 27, 2022

richieteh94 commented Sep 1, 2022 • edited Loading

richieteh94 commented Sep 1, 2022 •

edited

Loading