Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Followup on #661 #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
Loading
from
Open

Followup on #661 #672

wants to merge 3 commits into from

Conversation

markandrus
Copy link
Member

@markandrus markandrus commented Dec 25, 2020 •
edited
Loading

This PR includes follow up changes on #661. I updated web-platform-tests and made some small changes to pass a few more tests.

Changes:

  • Update CHANGELOG.md (not complete, still needs some entries).
  • Added RTCPeerConnectionIceErrorEvent to exports.
  • Fix "icecandidateerror" event (ICE candidates weren't correctly represented).
  • Add tests for Node 15 in Appveyor.
    • Also updated CircleCI to test Node 15, and culled old Node versions. Note that this doesn't mean we no longer support these Node versions, only that we'll no longer test them. This is due in part to an incompatibility introduced in the queue-microtask library, with respect to Node 11 and globalThis.
  • maxRetransmitTime and maxRetransmits should be properly optional and no longer default to -1.
  • Some error scenarios are more accurately represented now.
  • Added support for the "stopped" RTCRtpTransceiverDirection.
  • Added support for the NV12 pixel format.
  • MediaStreams will now properly release themselves on destruction.
  • RTCDtlsTransports will now properly release themselves on destruction.
  • removeTrack errors are now exposed in the API on RTCPeerConnection.
  • canTrickleIceCandidates is now supported.
  • setDirection errors are now exposed in the API on RTCRtpTransceiver.
  • stop errors are now exposed in the API on RTCRtpTransceiver.
  • WPT-related code has been re-imported from JSDom.
  • WPT tests have been updated, and new tests are passing.
  • CircleCI now builds with Xcode 9.4.1.

@markandrus
Copy link
Member Author

Waiting for clarification on some node-addon-api behavior here.

markandrus added a commit that referenced this pull request Jan 10, 2021
@markandrus
Release v0.4.7
d4ff78e 
The Circle CI configuration is outdated for Darwin. Also, there are open issues
with N-API to deal with here: #672

As such, it's difficult to get a clean build at the moment (and it will take
longer to fix some known segmentation fauls). Therefore, for the time being,
this release (since it changes only `package.json`) will just reuse binaries
from the v0.4.6 release. I've made the update in S3 manually.
@duvallj duvallj mentioned this pull request May 2, 2024
Open
3 tasks
duvallj pushed a commit to WonderInventions/node-webrtc that referenced this pull request Sep 10, 2024
@geekuillaume @duvallj
Tweaks
d976350 
node-webrtc#672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markandrus @geekuillaume
Morty Proxy This is a proxified and sanitized view of the page, visit original site.