Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

update unit test example#329

Open
Stwissel wants to merge 2 commits intonode-red:masternode-red/node-red.github.io:masterfrom
Stwissel:unit-test-updateStwissel/node-red.github.io:unit-test-updateCopy head branch name to clipboard
Open

update unit test example#329
Stwissel wants to merge 2 commits intonode-red:masternode-red/node-red.github.io:masterfrom
Stwissel:unit-test-updateStwissel/node-red.github.io:unit-test-updateCopy head branch name to clipboard

Conversation

@Stwissel
Copy link

@Stwissel Stwissel commented Nov 9, 2023

Got confused why unit test didn't work, learned the documentation is outdated.
I'd like to save others that learning experience :-)

Fixes #328

(formatting changes by pretttierJS sorry - hope it isn't an issue)

(formatting cganges by pretttier)
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Stwissel
Copy link
Author

@knolleary - merge this?

@dceejay
Copy link
Member

dceejay commented Oct 23, 2024

Hi - sorry - there seem to be lots of formatting changes that aren't actual changes - That make it hard to spot the real changes... any chance you can undo them ?

@knolleary
Copy link
Member

TBH, no problem with the formatting changes - they are all sensible. The bit that caused me to pause previously was adding node-red as a full dev dependency. That doesn't feel optimal, but I'm not sure how to describe the alternatives better in the docs. Will noodle on it some more.

@Stwissel
Copy link
Author

I'm curious. The test helper depends on nodeRED. How to get around it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit testing sample code doesn't match test-helper

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.