-
Notifications
You must be signed in to change notification settings - Fork 532
reimplementation of gpu_count #3718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
effigies
merged 3 commits into
nipy:master
from
mauriliogenovese:FIX-gputil-error-on-window
Mar 19, 2025
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
reimplementation of gpu_count
- Loading branch information
commit 4dfbbbee48fb92927dacb1905dc77bb5ed7382e4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# -*- DISCLAIMER: this file contains code derived from gputil (https://github.com/anderskm/gputil) | ||
# and therefore is distributed under to the following license: | ||
# | ||
# MIT License | ||
# | ||
# Copyright (c) 2017 anderskm | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all | ||
# copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
|
||
import platform | ||
import shutil | ||
from subprocess import Popen, PIPE | ||
import os | ||
|
||
|
||
def gpu_count(): | ||
try: | ||
if platform.system() == "Windows": | ||
nvidia_smi = shutil.which('nvidia-smi') | ||
if nvidia_smi is None: | ||
nvidia_smi = ( | ||
"%s\\Program Files\\NVIDIA Corporation\\NVSMI\\nvidia-smi.exe" | ||
% os.environ['systemdrive'] | ||
) | ||
else: | ||
nvidia_smi = "nvidia-smi" | ||
|
||
p = Popen( | ||
[nvidia_smi, "--query-gpu=name", "--format=csv,noheader,nounits"], | ||
stdout=PIPE, | ||
) | ||
stdout, stderror = p.communicate() | ||
|
||
output = stdout.decode('UTF-8') | ||
lines = output.split(os.linesep) | ||
num_devices = len(lines) - 1 | ||
return num_devices | ||
except: | ||
return 0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal is to keep it as close to the source as possible, that's fine. Here are some cleanups for your consideration:
shutil.which()
unconditionally. We can detect aFileNotFoundError
before calling the process and simply return 0.subprocess.run
, which is the recommended API. By using text mode, we don't have to handle decoding or newline normalization.FileNotFoundError
andPermissionError
(bothOSError
s) should catch failures to run.UnicodeDecodeError
will catch bad output.p.output.splitlines()
to get content-full lines. A trailing newline does not produce an empty string at the end of the list.