Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7a7165e

Browse filesBrowse files
nico-incubiqnicolas-grekas
authored andcommitted
Allow running PHPUnit with "xdebug.scream" ON
Since symfony#25733 the Kernel attempts to unlink the legacy container while being built. This throws an error if the file did not exist, for example on a clean install, on the build, which is then silenced. That's fine on production systems, but on our build we have enabled "xdebug.scream" in order to visualise every errors, which basically un-silences the errors. I believe there should not be a need to silence anything on a usual, clean usage of the system. Making this `unlink` conditional fixes it. Could you please approve and merge this PR? Thanks
1 parent 7fa13be commit 7a7165e
Copy full SHA for 7a7165e

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed

‎src/Symfony/Component/HttpKernel/Kernel.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Kernel.php
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,10 @@ protected function dumpContainer(ConfigCache $cache, ContainerBuilder $container
862862
$fs->dumpFile($dir.$file, $code);
863863
@chmod($dir.$file, 0666 & ~umask());
864864
}
865-
@unlink(\dirname($dir.$file).'.legacy');
865+
$legacyFile = \dirname($dir.$file).'.legacy';
866+
if (file_exists($legacyFile)) {
867+
@unlink($legacyFile);
868+
}
866869

867870
$cache->write($rootCode, $container->getResources());
868871
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.