auto/lib/zlib: fix zlib-ng build bug—skip distclean when no Makefile & add configure option #644
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build system had two issues when zlib-ng is used: 1. `distclean` was always invoked, causing failure on first run when no Makefile exists yet. 2. There was no way to pass options like --zlib-compat to zlib's ./configure; users tried to sneak them in via CFLAGS which triggers "compiler error reporting is too harsh" and aborts. The new --with-zlib-conf-opt=<opts> option feeds its value directly to ./configure, and `distclean` is now executed only if a Makefile is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build system had two issues when zlib-ng is used:
distcleanwas always invoked, causing failure on first run when no Makefile exists yet.The new --with-zlib-conf-opt= option feeds its value directly to ./configure, and
distcleanis now executed only if a Makefile is present.