Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: add OCC command to list all routes (incl. fixing the Router) #52919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
Loading
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 16, 2025

Summary

Main idea was to add a command to list all registered routes, to make the annotation more usable.
But when doing so I noticed the Router is broken as retrieving individual collections of routes was broken,
so this also contains a fix for it:

  • Add routes to individual collections for each app
    and then merge them for the root collection holding all routes for the
    URL generator.
  • Short cut route loading with already loaded apps
  • Simplify active collection handling
  • Remove deprecated OC_App usage
  • Fully type Router methods

Checklist

susnux added 2 commits May 17, 2025 00:55
- Add routes to individual collections for each app
  and then merge them for the root collection holding all routes for the
  URL generator.
- Short cut route loading with already loaded apps
- Simplify active collection handling
- Remove deprecated `OC_App` usage
- Fully type Router methods

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 32 milestone May 16, 2025
@susnux susnux added enhancement 2. developing Work in progress labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.