Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(files_sharing): remove queueUpdate and auto-saving behavior #52878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented May 15, 2025

  • Removed queueUpdate method from SharesMixin
  • Removed all auto-saving calls to queueUpdate across components
  • Ensured share modifications are only saved on explicit user action
  • Updated components to handle share state changes locally until save
  • Cleaned up related code and comments

This change makes the share modification behavior more predictable by requiring explicit save actions instead of auto-saving on every change.

Resolves: #52795

- Removed queueUpdate method from SharesMixin
- Removed all auto-saving calls to queueUpdate across components
- Ensured share modifications are only saved on explicit user action
- Updated components to handle share state changes locally until save
- Cleaned up related code and comments

This change makes the share modification behavior more predictable by
requiring explicit save actions instead of auto-saving on every change.

Resolves: #52795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Link share changes inconsistent storing (save / auto)
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.