pref: improve caledar object query performance and accuracy #52746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c70a78c to
e419ba2
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
e419ba2 to
7e9090b
Compare
|
Odd index is failing on CI but not on dev |
kesselb
requested changes
May 11, 2025
| @@ -50,6 +50,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op | ||
| } | ||
| $calendarObjectsTable->addUniqueIndex(['calendarid', 'calendartype', 'uri'], 'calobjects_index'); | ||
| $calendarObjectsTable->addUniqueIndex(['calendarid', 'calendartype', 'uid'], 'calobjects_by_uid_index'); | ||
| $calendarObjectsTable->addUniqueIndex(['calendarid', 'calendartype', 'firstoccurence', 'lastoccurence'], 'calobjects_by_time_index'); |
There was a problem hiding this comment.
Suggested change
| $calendarObjectsTable->addUniqueIndex(['calendarid', 'calendartype', 'firstoccurence', 'lastoccurence'], 'calobjects_by_time_index'); | |
| $calendarObjectsTable->addIndex(['calendarid', 'calendartype', 'firstoccurence', 'lastoccurence'], 'calobjects_by_time_index'); |
| // case 2: event starts before range and ends within range | ||
| // case 3: event starts within range and ends after range | ||
| // case 4: event starts before range and ends after range | ||
| $rangerStart = $timeRange['start']->getTimeStamp(); |
There was a problem hiding this comment.
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
CI is running the code from the migration, and there you've added a unique index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Before index
After index
Checklist