This repository was archived by the owner on May 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
prepare for deprecating with README and MIGRATING.md #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstavchansky
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but left some suggestions for quick edits.
Co-authored-by: rstavchansky <rachael@netlify.com>
Co-authored-by: rstavchansky <rachael@netlify.com>
I just realized I was merging @rstavchansky's changes thinking this was my PR. sorry about that 😬 |
jlengstorf
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on @rstavchansky's edits, but this looks great!
Co-authored-by: rstavchansky <rachael@netlify.com>
Co-authored-by: rstavchansky <rachael@netlify.com>
Co-authored-by: rstavchansky <rachael@netlify.com>
Co-authored-by: rstavchansky <rachael@netlify.com>
Co-authored-by: rstavchansky <rachael@netlify.com>
lindsaylevine
commented
Mar 6, 2021
lindsaylevine
added a commit
that referenced
this pull request
Mar 6, 2021
* prepare for deprecating with README and MIGRATING.md * fix: update capitalization Co-authored-by: rstavchansky <rachael@netlify.com> * fix: add name, formatting Co-authored-by: rstavchansky <rachael@netlify.com> * fix: plugin capitalization Co-authored-by: rstavchansky <rachael@netlify.com> * fix: formatting for brand new users section Co-authored-by: rstavchansky <rachael@netlify.com> * fix: caps + period Co-authored-by: rstavchansky <rachael@netlify.com> * fix: bullet point + formatting Co-authored-by: rstavchansky <rachael@netlify.com> * fix: second bullet point Co-authored-by: rstavchansky <rachael@netlify.com> * fix: caps build plugin Co-authored-by: Jason Lengstorf <jason.lengstorf@netlify.com> Co-authored-by: rstavchansky <rachael@netlify.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.