Add databse string example #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DB url requires some extra parameters to work
keiko713
reviewed
Apr 10, 2020
|
|
||
| The connection string requires the following two parameters: `?parseTime=true&multiStatements=true` | ||
|
|
||
| Eg: `mysql://user:pass@tcp(127.0.0.1:3306)/database?parseTime=true&multiStatements=true` |
There was a problem hiding this comment.
thanks for the PR! adding this sounds good. how about adding this ?parseTime=true&multiStatements=true in the above example in line 60 (also you don't need mysql:// there)?
then we can keep the line 71, to explain it's needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DB url requires some extra parameters to work
- Summary
Might as well describe this in the readme as it is a requirement to use the service.
- Test plan
Documentation only
- Description for the changelog
Added an example database URI
- A picture of a cute animal (not mandatory but encouraged)