Adjust result when NULL (MSSQL). #21417
Draft
+84
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some queries can return NULL values (mainly in replication scenarios). To prevent potential issues, this PR ensures values are set whenever the final query delivers a NULL.
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Handle MSSQL NULL results across the Windows plugin collectors by defaulting numeric fields to 0 and strings to empty, preventing bad metrics and errors, especially in replication and status queries.
Written for commit 09545b3. Summary will update automatically on new commits.