Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[RFC] Fix environment variable on Windows #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RFC] Fix environment variable on Windows #9681

wants to merge 1 commit into from

Conversation

erw7
Copy link
Contributor

@erw7 erw7 commented Mar 5, 2019

This PR will fix the following problem.

Steps to reproduce using nvim -u NORC

nvim -u NORC
:let $XTEST_1='foo'
:echo getcompletion('XTEST_', 'environment')
:lua print(os.getenv('XTEST_1'))

Actual behaviour

[]
nil

Expected behaviour

[XTEST_1]
foo

@erw7
Fix environment variable on Windows
f7a98fb 
Since uv_os_setenv uses SetEnvironmentVariableW, _wenviron is not
updated. As a result, inconsistency occurs in os.getenv of lua and
completion of environment variable names. To solve this, implemented an
alternative function to the libuv function.
@marvim marvim added the RFC label Mar 5, 2019
@erw7 erw7 mentioned this pull request Mar 6, 2019
Merged
@erw7 erw7 closed this Mar 6, 2019
justinmk added a commit that referenced this pull request Mar 16, 2019
@justinmk
Merge #9686 'win/Lua: monkey-patch os.getenv()'
11a481f 
fixes #9681
@erw7 erw7 deleted the fix-env-var-on-windows branch September 11, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erw7 @justinmk @marvim
Morty Proxy This is a proxified and sanitized view of the page, visit original site.