feat(spell): add option for downloading spellfiles without confirmation #36836
+58
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd912de to
dad3ae0
Compare
justinmk
reviewed
Dec 6, 2025
justinmk
approved these changes
Dec 6, 2025
Member
justinmk
left a comment
There was a problem hiding this comment.
No major objection but we should start thinking about a global flag similar to the existing 'confirm' option, because it's getting pretty repetivie to add these flags everywhere. Unfortunately the existing 'confirm' has a very narrow purpose and likely can't be re-used :(
Also if more enhancements are planned for this we need to find a way to not have 30 lines of new test code for every trivial feature. But for this PR I don't see a way to avoid it.
dad3ae0 to
768d17f
Compare
justinmk
reviewed
Dec 6, 2025
| rtp_dir | ||
| ) | ||
|
|
||
| neq(0, out.requests) |
Member
There was a problem hiding this comment.
Just for future reference, t.ok usually enables more meaningful tests instead of neq:
t.ok(out.requests > 0, '>0', out.requests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Setups which wish to download files non-interactively via
nvim --headless +qall!have no way to configurespellfile.luato download files without prompting. Additionally, some users with a fast internet connection may wish to avoid a prompt when downloading spellfiles interactively.Solution
Based off of
vim.pack.add()'sconfirmoption, which allows for downloading plugins without confirmation, introduce a similar option to the builtinspellfile.luaplugin. This option defaults totrue, so there is no change in behavior for users which do not opt in.