Diagnostic handlers for diagnostics at EOL are inconsistent

Problem

The diagnostic handler for opening the floating preview window has special handling for diagnostics at the end of the line.

neovim/runtime/lua/vim/diagnostic.lua

Lines 2181 to 2189 in 570e62d

    
           -- If `col` is past the end of the line, show if the cursor is on the last char in the line 
        
           local line_length = #api.nvim_buf_get_lines(bufnr, lnum, lnum + 1, true)[1] 
        
           --- @param d vim.Diagnostic 
        
           diagnostics = vim.tbl_filter(function(d) 
        
             return lnum >= d.lnum 
        
               and lnum <= d.end_lnum 
        
               and (lnum ~= d.lnum or col >= math.min(d.col, line_length - 1)) 
        
               and ((d.lnum == d.end_lnum and d.col == d.end_col) or lnum ~= d.end_lnum or col < d.end_col) 
        
           end, diagnostics)

However, other handlers, such as the underline one, do not do this, which can lead to a surprising user experience (e.g., if you auto-summon the window when on a diagnostic, it will appear in places where there aren't diagnostic indicators). Can the handlers be made consistent?

Nvim version (nvim -v)

0.11.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Diagnostic handlers for diagnostics at EOL are inconsistent #34013

Problem

Nvim version (nvim -v)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	-- If `col` is past the end of the line, show if the cursor is on the last char in the line
	local line_length = #api.nvim_buf_get_lines(bufnr, lnum, lnum + 1, true)[1]
	--- @param d vim.Diagnostic
	diagnostics = vim.tbl_filter(function(d)
	return lnum >= d.lnum
	and lnum <= d.end_lnum
	and (lnum ~= d.lnum or col >= math.min(d.col, line_length - 1))
	and ((d.lnum == d.end_lnum and d.col == d.end_col) or lnum ~= d.end_lnum or col < d.end_col)
	end, diagnostics)

Search code, repositories, users, issues, pull requests...

Uh oh!

Diagnostic handlers for diagnostics at EOL are inconsistent #34013

Description

Problem

Nvim version (nvim -v)

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions