Add background image continuation #3067
Conversation
opacity -> normal_opacity transparency -> opacity
website/docs/configuration.md
Outdated
|
|
||
| Use the `g:neovide_background_image` variable to set a background image for Neovide. It is set to a string url. | ||
|
|
||
| You can alter the background images transparency by changing the `g:neovide_background_transparency` variable. It takes a value ranging from 0.0 (transparent) to 1.0 (opaque). |
There was a problem hiding this comment.
This could be renamed to opacity to be consistent with the other _opacity settings. I also think that it would make sense to include image to avoid confusion. So, perhaps neovide_bgimage_opacity?
| &screen_rect, | ||
| grid_scale, | ||
| ) | ||
| }) |
There was a problem hiding this comment.
There's something wrong here, probably with these changes, but it could be something else. Without setting any transparency option, or background image, the border becomes transparent
| &screen_rect, | ||
| grid_scale, | ||
| ) | ||
| }) |
There was a problem hiding this comment.
This is probably also a problem with this code, the normal opacity setting does not work properly (the right is Neovide main)
Without a background image it does not function at all
| &screen_rect, | ||
| grid_scale, | ||
| ) | ||
| }) |
There was a problem hiding this comment.
The rendering stops working after resizing the window with neovide_opacity set and maximizing the window
| vim.g.neovide_background_image = "~/image.jpg" | ||
| ``` | ||
|
|
||
| Using a background image in conjunction with `g:neovide_opacity` can lead to some nice looking results. Especially when using a more subtle texture instead of a regular image. |
There was a problem hiding this comment.
I think we need to document that the feature requires either neovide_opacity or neovide_normal_opacity, otherwise the image will be hidden behind the background
This pr relates to issue: #342 and pr: #2419.
This is a continuation on mysty0s pr.
Adds two new settings
vim.g.neovide_background_imageandvim.g.neovide_background_transparency.What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.