Implement corner preference #2825
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can you rebase onto the latest main? That will fix the Clippy errors. And before this can be merged the new options need to be documented. Finally, you need to apply the settings when the window is created here neovide/src/window/window_wrapper.rs Line 432 in 71602b3 |
|
For the documentation can you also add the neovide/website/docs/configuration.md Line 335 in 281a062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be most of the initial work for implementing the corner preference windows window setting as described in #2665. I haven't actually built this on a windows machine yet, so there are probably pieces missing and small mistakes I haven't noticed.
Note that the setter is invoked unconditionally as I could not find a getter in the winit docs.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?