build: update version #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Moving to project.version creates the following warnings:
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.neo4j:neo4j-streams-common:jar:5.0.8
[WARNING] 'version' contains an expression but should be a constant. @ org.neo4j:neo4j-streams-common:${project.version}, /Users/fbiville/workspace/neo4j-streams/common/pom.xml, line 11, column 14
[WARNING] 'version' contains an expression but should be a constant. @ org.neo4j:neo4j-streams-parent:${project.version}, /Users/fbiville/workspace/neo4j-streams/pom.xml, line 7, column 14
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.neo4j:neo4j-streams-test-support:jar:5.0.8
[WARNING] 'version' contains an expression but should be a constant. @ org.neo4j:neo4j-streams-test-support:${project.version}, /Users/fbiville/workspace/neo4j-streams/test-support/pom.xml, line 11, column 14
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.neo4j:kafka-connect-neo4j:jar:5.0.8
[WARNING] 'version' contains an expression but should be a constant. @ org.neo4j:kafka-connect-neo4j:${project.version}, /Users/fbiville/workspace/neo4j-streams/kafka-connect-neo4j/pom.xml, line 11, column 14
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.neo4j:neo4j-streams-parent:pom:5.0.8
[WARNING] 'version' contains an expression but should be a constant. @ org.neo4j:neo4j-streams-parent:${project.version}, /Users/fbiville/workspace/neo4j-streams/pom.xml, line 7, column 14
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
Ok instead i'll probably just remove the tags entirely from the sub-modules since they aren't needed. It'll then inherit the parents version. How does that sound? |
fbiville
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build