Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Extend conditional #7868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 31 commits into from
Closed

Extend conditional #7868

wants to merge 31 commits into from

Conversation

khalidadil
Copy link
Contributor

@khalidadil khalidadil commented Oct 4, 2024 •
edited by akhenry
Loading

Closes #8082
Closes #8083

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

jvigliotta and others added 28 commits September 12, 2024 09:28
@jvigliotta
adding telemetry collections to condition manager
b4fdabf
@jvigliotta
handling telemetry collection data not datum
5bd5ca9
@jvigliotta
adding from maaster
4ab19e3
@jvigliotta
addressing PR comments
b467f9c
@jvigliotta
Merge branch 'master' into conditional-style-performance
3f66140
@jvigliotta
update unit test to work with telemetry collections
6482135
@jvigliotta
fixing tests
54c90e0
@jvigliotta
removing unnecessary addition
94a4ff3
@jvigliotta
removing focused describe
7cba09b
@jvigliotta
removing focused it
405b497
@jvigliotta
Merge branch 'master' into conditional-style-performance
1581216
@jvigliotta
fix weird test bleed
5b385ea
@jvigliotta
Merge branch 'conditional-style-performance' of https://github.com/na…
73489cd 
…sa/openmct into conditional-style-performance

mergin master
@khalidadil
Add realtime output of telemetry data in conditionals and add support…
23cf829 
… for historical conditional telemetry queries to allow for plotting
@khalidadil
Cleanup and add missing files
21e94fd
@khalidadil
Fix issue with missing data
101baa5
@khalidadil
Update emitted values
7896f36
@khalidadil
Addressing feedback
4b39ea2
@khalidadil
Creating a const for telemetry value
b975554
@khalidadil
Cleanup
7727a90
@khalidadil
Pass through plot options
f544a1d
@khalidadil
Cleanup
1180597
@khalidadil
Fix problem introduced with const
39a73cf
@khalidadil
Add back initialize on mount
0f2f71f
@khalidadil
Compensate for missing data at certain timestamps
4a3b0b9
@khalidadil
Rename file
a739d61
@khalidadil
Rename file
488178a
@khalidadil
Update metadata provider
f239d4b
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 5.37190% with 229 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.20%. Comparing base (de122b9) to head (cba2056).
⚠️ Report is 61 commits behind head on master.

Files with missing lines Patch % Lines
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% 145 Missing ⚠️
src/plugins/condition/ConditionManager.js 0.00% 63 Missing ⚠️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% 9 Missing ⚠️
.../plugins/condition/ConditionSetMetadataProvider.js 0.00% 7 Missing ⚠️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 70.00% 3 Missing ⚠️
...plugins/condition/ConditionSetTelemetryProvider.js 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (de122b9) and HEAD (cba2056). Click for more details.

HEAD has 40 uploads less than BASE
Flag BASE (de122b9) HEAD (cba2056)
unit 19 0
e2e-full 18 1
e2e-ci 7 3
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7868      +/-   ##
==========================================
- Coverage   59.18%   50.20%   -8.99%     
==========================================
  Files         675      435     -240     
  Lines       27284    13755   -13529     
  Branches     2671        0    -2671     
==========================================
- Hits        16149     6906    -9243     
+ Misses      11088     6849    -4239     
+ Partials       47        0      -47
Flag Coverage Δ
e2e-ci ∅ <5.37%> (∅)
e2e-full ∅ <1.65%> (∅)
unit ?
Files with missing lines Coverage Δ
src/plugins/condition/plugin.js 100.00% <100.00%> (ø)
src/plugins/condition/utils/constants.js 100.00% <100.00%> (ø)
src/plugins/plot/tickUtils.js 74.64% <100.00%> (-22.54%) ⬇️
...plugins/condition/ConditionSetTelemetryProvider.js 9.52% <0.00%> (-85.48%) ⬇️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 85.41% <70.00%> (+1.10%) ⬆️
.../plugins/condition/ConditionSetMetadataProvider.js 16.66% <0.00%> (-83.34%) ⬇️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% <18.18%> (ø)
src/plugins/condition/ConditionManager.js 0.00% <0.00%> (-91.00%) ⬇️
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% <0.00%> (ø)

... and 441 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de122b9...cba2056. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jvigliotta jvigliotta self-requested a review July 16, 2025 19:03
@jvigliotta jvigliotta mentioned this pull request Aug 26, 2025
Open
14 tasks
@jvigliotta jvigliotta closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvigliotta jvigliotta Awaiting requested review from jvigliotta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support a mode where Condition Sets emit the underlying telemetry value when true Support conditional evaluation of historical telemetry

2 participants

@khalidadil @jvigliotta
Morty Proxy This is a proxified and sanitized view of the page, visit original site.