feat!(napi): support custom tsfn error status #2672
Merged
Brooooooklyn merged 1 commit intonapi-rs:mainnapi-rs/napi-rs:mainfrom Jun 2, 2025
h-a-n-a:custom-tsfn-result-codeh-a-n-a/napi-rs:custom-tsfn-result-codeCopy head branch name to clipboard
Merged
feat!(napi): support custom tsfn error status #2672Brooooooklyn merged 1 commit intonapi-rs:mainnapi-rs/napi-rs:mainfrom h-a-n-a:custom-tsfn-result-codeh-a-n-a/napi-rs:custom-tsfn-result-codeCopy head branch name to clipboard
Brooooooklyn merged 1 commit intonapi-rs:mainnapi-rs/napi-rs:mainfrom
h-a-n-a:custom-tsfn-result-codeh-a-n-a/napi-rs:custom-tsfn-result-codeCopy head branch name to clipboard
Conversation
Brooooooklyn
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support passing custom error status to TSFN so we can receive custom error codes from the JavaScript side.
The only constraint it has is to convert from
napi::Statusto your custom status. This is required to allow some of the methods that still uses defaultErrorto work with custom error status.