napi-rs
diff --git a/‎.github/workflows/test-release.yaml
Copy file name to clipboardExpand all lines: .github/workflows/test-release.yaml
+1-12Lines changed: 1 addition & 12 deletions b/‎.github/workflows/test-release.yaml
Copy file name to clipboardExpand all lines: .github/workflows/test-release.yaml
+1-12Lines changed: 1 addition & 12 deletions
diff --git a/‎crates/napi/src/js_values/mod.rs
Copy file name to clipboardExpand all lines: crates/napi/src/js_values/mod.rs
+13-2Lines changed: 13 additions & 2 deletions b/‎crates/napi/src/js_values/mod.rs
Copy file name to clipboardExpand all lines: crates/napi/src/js_values/mod.rs
+13-2Lines changed: 13 additions & 2 deletions
@@ -71,8 +71,7 @@ jobs:
             build: yarn build:test
             test: |
               yarn test:cli
-              ulimit -c unlimited
-              sudo yarn test
+              DEBUG="*" yarn test
               yarn tsc -p examples/napi/tsconfig.json --noEmit --skipLibCheck
               yarn test:macro
             toolchain: stable
@@ -206,16 +205,6 @@ jobs:
           NODE_OPTIONS: '--max-old-space-size=8192'
           DISABLE_V8_COMPILE_CACHE: 1
 
-      - name: chmod core files
-        if: ${{ failure() && matrix.settings.target == 'x86_64-unknown-linux-gnu' }}
-        run: sudo chmod -R +rwx /cores/*
-
-      - uses: actions/upload-artifact@v4
-        if: ${{ failure() }}
-        with:
-          name: crashes
-          path: /cores
-
       - name: Electron tests
         if: matrix.settings.target == 'aarch64-apple-darwin' || matrix.settings.target == 'x86_64-pc-windows-msvc'
         run: |
 
@@ -249,14 +249,25 @@ pub trait JsObjectValue<'env>: JsValue<'env> {
 
   fn get_property<'k, K, T>(&self, key: K) -> Result<T>
   where
-    K: JsObjectValue<'k>,
-    T: FromNapiValue,
+    K: JsValue<'k>,
+    T: FromNapiValue + ValidateNapiValue,
   {
     let mut raw_value = ptr::null_mut();
     let env = self.value().env;
     check_status!(unsafe {
       sys::napi_get_property(env, self.value().value, key.raw(), &mut raw_value)
     })?;
+    unsafe { T::validate(env, raw_value) }.map_err(|mut err| {
+      err.reason = format!(
+        "Object property '{:?}' type mismatch. {}",
+        key
+          .coerce_to_string()
+          .and_then(|s| s.into_utf8())
+          .and_then(|s| s.into_owned()),
+        err.reason
+      );
+      err
+    })?;
     unsafe { T::from_napi_value(env, raw_value) }
   }