fixes issues with MemoryModule function#2
Merged
naksyn merged 1 commit intonaksyn:mainnaksyn/PythonMemoryModule:mainfrom Jan 8, 2023
rkbennett:mainCopy head branch name to clipboard
Merged
fixes issues with MemoryModule function#2naksyn merged 1 commit intonaksyn:mainnaksyn/PythonMemoryModule:mainfrom rkbennett:mainCopy head branch name to clipboard
naksyn merged 1 commit intonaksyn:mainnaksyn/PythonMemoryModule:mainfrom
rkbennett:mainCopy head branch name to clipboard
Conversation
… veunicode strings and nd LPCSTR ord cast
Owner
|
Thank you for you contribution @rkbennett, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #1, caused by in invalid function reference in pefile, and also some string type issues, when running in python 3.10. This imports pythonmemorymodule.ordlookup as ordlookup to address the first issue. For the second, I added a check to see if ordinal had the decode method, and only attempts decode if it does. Then I added an explicit cast to LPCSTR, which should allow compatibility regardless of the value types are returned by importordinal.