Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

2.1.0 #1094

bgrainger started this conversation in General
2.1.0 #1094
Nov 28, 2021 · 1 comments · 4 replies
Discussion options

MySqlConnector.Logging.Microsoft.Extensions.Logging


This discussion was created from the release 2.1.0.
You must be logged in to vote

Replies: 1 comment · 4 replies

Comment options

I see that 2.1.x nugets ship assembly with 2.0.0 version. Is it expected change in v2 branch? v0/v1 releases had assembly version matching nuget version.

You must be logged in to vote
4 replies
@bgrainger
Comment options

bgrainger Feb 19, 2022
Maintainer Author

The version info on the DLL in the nupkg looks correct to me:

image

Are you talking about the strong name? MySqlConnector, Version=2.0.0.0, Culture=neutral, PublicKeyToken=d33d3e53aa5f8c92

@bgrainger
Comment options

bgrainger Feb 19, 2022
Maintainer Author

Are you talking about the strong name?

If yes, then note that this is a recommended best practice:

✔️ CONSIDER only including a major version in the AssemblyVersion.

https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/versioning#assembly-version

@MaceWindu
Comment options

Yep, version in strong name (one, returned by assembly.GetName().Version). I'm fine with it, just wanted to confirm it's expected behavior, as we used version for feature detection for older versions.

@bgrainger
Comment options

bgrainger Feb 20, 2022
Maintainer Author

OK, yes it is expected behaviour.

v0/v1 releases had assembly version matching nuget version.

AFAIK they had a major-number-only strong name version, too.

I don't actually know exactly where it comes from. The build chain generates [assembly: System.Reflection.AssemblyVersionAttribute("2.0.0.0")] in src\MySqlConnector\obj\Release\net6.0\MySqlConnector.AssemblyInfo.cs so something in the standard build chain decides to use only a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.